Skip to content

Fix gateway default mode to routed#492

Merged
lpcox merged 3 commits intomainfrom
copilot/confirm-gateway-mode-and-test-logs
Jan 27, 2026
Merged

Fix gateway default mode to routed#492
lpcox merged 3 commits intomainfrom
copilot/confirm-gateway-mode-and-test-logs

Conversation

Copy link
Contributor

Copilot AI commented Jan 27, 2026

Gateway was defaulting to unified mode when no --routed or --unified flag was specified, contradicting documentation and run.sh behavior.

Changes

  • Fixed default mode: Changed internal/cmd/root.go to default to routed mode instead of unified

    // Before: defaulted to unified
    mode := "unified"
    if routedMode {
        mode = "routed"
    }
    
    // After: defaults to routed
    mode := "routed"
    if unifiedMode {
        mode = "unified"
    }
  • Added tests: Verified non-existent tool call handling in both modes (nonexistent_tool_logging_test.go)

Tool Name Behavior

Confirmed and tested tool name exposure differs by mode:

Mode Endpoint Tool Name Format Example
Routed (default) /mcp/{serverID} No prefix "create-issue"
Unified /mcp With prefix "safeoutputs___create-issue"

Non-existent tool calls properly return JSON-RPC errors and are logged via existing infrastructure.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • nonexistent.local
    • Triggering command: /tmp/go-build98642035/b269/launcher.test /tmp/go-build98642035/b269/launcher.test -test.testlogfile=/tmp/go-build98642035/b269/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/cgo --local x_amd64/vet user.email pVvZn2gawien (dns block)
  • this-host-does-not-exist-12345.com
    • Triggering command: /tmp/go-build98642035/b278/mcp.test /tmp/go-build98642035/b278/mcp.test -test.testlogfile=/tmp/go-build98642035/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/c-test.run=TestNonExistentToolCallLogging jXVyRLCVa x_amd64/vet pull.rebase boring/sig (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits January 27, 2026 16:11
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot AI changed the title [WIP] Confirm gateway runs in routed mode and test tool exposure Fix gateway default mode to routed Jan 27, 2026
Copilot AI requested a review from lpcox January 27, 2026 16:16
@lpcox lpcox marked this pull request as ready for review January 27, 2026 16:17
@lpcox lpcox merged commit a6f3222 into main Jan 27, 2026
3 checks passed
@lpcox lpcox deleted the copilot/confirm-gateway-mode-and-test-logs branch January 27, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants